[DO-NOT-MERGE] Bump react-hotkeys-hook from 3.4.7 to 4.5.0 #2354
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [react-hotkeys-hook](https://github.com/JohannesKlauss/react-keymap-hook) from 3.4.7 to 4.5.0. - [Release notes](https://github.com/JohannesKlauss/react-keymap-hook/releases) - [Changelog](https://github.com/JohannesKlauss/react-hotkeys-hook/blob/main/CHANGELOG.md) - [Commits](JohannesKlauss/react-hotkeys-hook@v3.4.7...v4.5.0) --- updated-dependencies: - dependency-name: react-hotkeys-hook dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
Changed
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/react-hotkeys-hook@3.4.7 |
There was a problem hiding this comment.
Do not merge this
The breaking change hits GUI
There are several locations using cmd key in the GUI.
- https://github.com/Chia-Network/chia-blockchain-gui/blob/main/packages/gui/src/components/offers/OfferImport.tsx#L139
- https://github.com/Chia-Network/chia-blockchain-gui/blob/main/packages/gui/src/components/offers2/OfferBuilderImport.tsx#L100
- https://github.com/Chia-Network/chia-blockchain-gui/blob/main/packages/gui/src/hooks/usePaste.ts#L11
We need to replace cmd with meta for macOS.
I'd suggest to create a replacement PR which updates react-hotkeys-hook and replaces cmd with meta.
ChiaMineJP
changed the title
|
Closed since I'm creating a new replacing branch. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps react-hotkeys-hook from 3.4.7 to 4.5.0.
Release notes
Sourced from react-hotkeys-hook's releases.
... (truncated)
Commits
f1606084.5.00d0ef09Group non major renovate PRs890e39aMerge pull request #1129 from MrMouthOG/feature/resetKeysWhenRecordingaf0d366Added clean keys while recording33c02ff4.4.4611a579Merge remote-tracking branch 'origin/main'74349b2Fix duplicate key activationefe75d1fix(deps): update dependency react-hotkeys-hook to v4.4.35b0661bchore(deps): update dependency@types/reactto v18.2.4795b5e4e4.4.3Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)