Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHIA-420 remove ignore for pkg_resources deprecation warning #17933

Merged
merged 10 commits into from May 15, 2024
Merged

CHIA-420 remove ignore for pkg_resources deprecation warning #17933

merged 10 commits into from May 15, 2024

Conversation

altendky
Copy link
Contributor

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Cleanup Code cleanup labels Apr 29, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label May 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label May 13, 2024
@altendky altendky changed the title remove ignore for pkg_resources deprecation warning CHIA-420 remove ignore for pkg_resources deprecation warning May 14, 2024
@altendky altendky marked this pull request as ready for review May 14, 2024 21:13
@altendky altendky requested a review from a team as a code owner May 14, 2024 21:13
@altendky altendky requested a review from emlowe May 14, 2024 21:14
@github-actions GitHub Actions
Copy link
Contributor

File Coverage Missing Lines
chia/timelord/timelord_launcher.py 75.0% lines 69-70
chia/wallet/puzzles/load_clvm.py 66.7% lines 104-105, 107-109
Total Missing Coverage
60 lines 7 lines 88%

@cmmarslender cmmarslender merged commit 73a7cb4 into main May 15, 2024
355 of 356 checks passed
@cmmarslender cmmarslender deleted the pkg_resources_deprectaion_cleanup branch May 15, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

Assignees
No one assigned
Labels
Cleanup Code cleanup Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@altendky @emlowe @cmmarslender