Add unfinished block to state change event #17976
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixbrucker
force-pushed
the
add-unfinished-block-to-state-change
branch
2 times, most recently
from
6c80d14
to
eda9d2d
Compare
felixbrucker
force-pushed
the
add-unfinished-block-to-state-change
branch
from
eda9d2d
to
fc5d0b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Expose unfinished blocks and relevant metrics to WS rpc api subscribers.
Current Behavior:
Currently only the fact that some unfinished block was added is emitted, but not which or with what data.
New Behavior:
The state change event now contains the unfinished block and relevant data, mainly processing and receive timings. To subscribe to them register the service
unfinished_block_info.