Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-292] Modify VerifiedCredential.launch to handle multiple source coins #17982

Merged
merged 3 commits into from May 16, 2024

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented May 7, 2024

Previously there was a bug where launching a VC with multiple coins (assuming you need a fee for example) would ail due to the driver's expectation that there would be only one. The patch modifies that driver to support multiple source coins.

@Quexington Quexington added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog VC labels May 7, 2024
@Quexington Quexington marked this pull request as ready for review May 7, 2024 17:16
@Quexington Quexington requested a review from a team as a code owner May 7, 2024 17:16
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label May 7, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot May 8, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot May 8, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label May 8, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot May 8, 2024
Copy link

Pull Request Test Coverage Report for Build 9005501291

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 3 files are covered.
  • 31 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.805%

Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node_api.py 1 81.0%
chia/timelord/timelord_launcher.py 1 69.92%
chia/introducer/introducer.py 1 78.26%
chia/data_layer/data_store.py 2 95.39%
chia/data_layer/data_layer_wallet.py 2 91.15%
chia/data_layer/data_layer.py 3 85.26%
chia/server/node_discovery.py 4 80.5%
chia/wallet/wallet_node.py 7 88.51%
chia/full_node/full_node.py 10 85.19%
Totals Coverage Status
Change from base Build 9002628913: -0.02%
Covered Lines: 98874
Relevant Lines: 108828

💛 - Coveralls

@Quexington Quexington closed this May 14, 2024
@Quexington Quexington reopened this May 14, 2024
@Quexington Quexington changed the title Modify VerifiedCredential.launch to handle multiple source coins [CHIA-292] Modify VerifiedCredential.launch to handle multiple source coins May 14, 2024
@Quexington Quexington closed this May 15, 2024
@Quexington Quexington reopened this May 15, 2024
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@cmmarslender cmmarslender merged commit d868d9c into main May 16, 2024
1054 checks passed
@cmmarslender cmmarslender deleted the quex.fix_vc_mint branch May 16, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog VC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants