[CHIA-302] Handle reorgs in data layer wallet #17992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
changed the title
Quexington
added
the
Fixed
emlowe
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started as an exploration into removing reorged mirrors from the data layer wallet DB and expanded due to the fact that nothing in the data layer DB was really being rolled back during a reorg. This isn't necessarily catastrophic because the wallet resubmits transactions to attempt to make the correct state match, but this can create periods of unpredictability. The PR adds a large test for the full lifecycle of a data layer wallet including reorgs and then handles all relevant side effects. This does result in behavior changes regarding the number and form of transactions returned, but nothing problematic I don't think.