New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Puzzle hash optimizations #17995
Merged
Merged
Puzzle hash optimizations #17995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
added
the
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
label
May 9, 2024
richardkiss
reviewed
May 9, 2024
richardkiss
reviewed
May 9, 2024
richardkiss
reviewed
May 9, 2024
richardkiss
requested changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Some minor nits.
…_pair() directly, rather than constructing a Program to call get_tree_hash() on.
arvidn
force-pushed
the
puzzle-hash-optimizations
branch
from
May 9, 2024 20:28
baa9ba8
to
463f12f
Compare
richardkiss
approved these changes
May 10, 2024
|
Pull Request Test Coverage Report for Build 9023140534Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
emlowe
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is best reviewed one commit at a time.
Purpose:
This PR aims to improve the performance of computing puzzle hashes. This is achieved in 3 commits:
[]
on the fly, use the constantNULL_TREEHASH
.Program
objects from values, just to compute the tree hash. Compute the tree hash directly from the values using the existingshatree_atom()
,shatree_pair()
, as well as introducingshatree_int()
andshatree_byte_list()
get_g1()
) multiple times, by wrappingcalculate_synthetic_public_key
andcalculate_synthetic_secret_key
in LRU caches.Current Behavior:
We waste time in
get_inner_puzhash_by_p2()
New Behavior:
We waste less time in
get_inner_puzhash_by_p2()
profile
get_inner_puzhash_by_p2()
puzzle_hash_for_public_key_and_hidden_puzzle_hash
before
after