Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-387] DL batch upsert optimization. #17999

Merged
merged 11 commits into from May 16, 2024
Merged

Conversation

fchirica
Copy link
Contributor

@fchirica fchirica commented May 9, 2024

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@fchirica fchirica added DataLayer Changed Required label for PR that categorizes merge commit message as "Changed" for changelog labels May 9, 2024
Copy link

Pull Request Test Coverage Report for Build 9024987415

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 60 of 61 (98.36%) changed or added relevant lines in 1 file are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.828%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/data_layer/data_store.py 60 61 98.36%
Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node.py 1 84.87%
chia/wallet/wallet_node.py 11 88.15%
Totals Coverage Status
Change from base Build 9018383795: 0.02%
Covered Lines: 99024
Relevant Lines: 108967

💛 - Coveralls

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label May 10, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label May 13, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@fchirica fchirica marked this pull request as ready for review May 13, 2024 15:35
@fchirica fchirica requested a review from a team as a code owner May 13, 2024 15:35
@fchirica fchirica requested review from altendky and emlowe May 13, 2024 16:48
@emlowe emlowe changed the title DL batch upsert optimization. [CHIA-387] DL batch upsert optimization. May 13, 2024
@fchirica fchirica added the ready_to_merge Submitter and reviewers think this is ready label May 15, 2024
@cmmarslender cmmarslender merged commit b7e8fe7 into main May 16, 2024
361 checks passed
@cmmarslender cmmarslender deleted the fc.dl_upsert_optimize branch May 16, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog DataLayer ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants