Add Docker build target for container that doesn't run as root #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `docker build --target no-root` will build a container image
without sudo and as the user/group `chia`. UID and GID can be adjusted
with the UID and GID build-arg parameters.
Gotchas:
* if volumes are mounted in the container, they must have open read/write
permissions if the host uid:gid for them is different than the
container's or the must have the same uid:gid as the container
* if the volumes are mounted but the intervening directories in the
mount path inside the container do not exist, docker will create those
directories as root:root by default, this will break permissions
|
the lint errors reported are not caused directly by this PR, but older code that may have existed before the linters were enabled |
|
'This PR has been flagged as stale due to no activity for over 60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#163
Add a Dockerfile target
no-rootthat will run chia blockchain binary as user/groupchia:chiaand does not havesudoinstalled. Final target in the Dockerfile allows building a container that runs as root and hassudo. People building the container can set the UID/GID that chia:chia will map to at build time. End users running the container must ensure that permissions work out properly for mounted directories in the chia:chia user/group if they are using the non-root container. This means either matching chia:chia's UID/GID with the host system user's UID/GID or modifying directory permissions on the host to allow read/writes by others (writes may be required for storing config files in a host-mounted directory)New no-root version with UID/GID matching the current user can be built with
docker build -t <tags> --build-arg UID=$(id -u) --build-arg GID=$(id -g) --build-arg BRANCH=<target version> --target no-root -f Dockerfile .