Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate cw-orch #831

Open
wants to merge 8 commits into
base: development
Choose a base branch
from
Open

Conversation

Kayanski
Copy link

@Kayanski Kayanski commented May 16, 2024

This PR aims at adding cw-orch inside Dao-Dao.
Tasks to fill :

  • Add a cw-orch-interface package with all the contract interfaces.
  • Add the derive macros on all execute and query msgs
  • Write tests using cw-orch syntax
  • Osmosis Test Tube tests
  • Include artifacts in there (at least in crates.io release).

@Kayanski Kayanski marked this pull request as ready for review May 17, 2024 09:14
@ismellike
Copy link
Contributor

Minor request
It would be great to use the id = <default contract id> syntax for the contract interfaces.
https://orchestrator.abstract.money/contracts/interfaces.html#creating-an-interface

@Kayanski
Copy link
Author

Minor request It would be great to use the id = <default contract id> syntax for the contract interfaces. https://orchestrator.abstract.money/contracts/interfaces.html#creating-an-interface

yes god idea !
However, when doing so, you won't be able to use the 2 same contracts inside a project. You wouldn't be able to test or script simply with 2 daos for instance, is that acceptable ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants