-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mailchimp/mailchimp_marketing] add extra args to searchMembers.search #69587
Conversation
searchMembers.search can have optinal parameters as per the docs https://mailchimp.com/developer/marketing/api/search-members/search-members/
@ExTBH Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 23 days — it is considered nearly abandoned! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69587,
"author": "ExTBH",
"headCommitOid": "0108547106feecafa39fe09f4a54812142563458",
"mergeBaseOid": "213785ea0d09abc2b89228d0a810e1597fabb18f",
"lastPushDate": "2024-05-13T10:41:26.000Z",
"lastActivityDate": "2024-05-13T10:41:26.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "mailchimp__mailchimp_marketing",
"kind": "edit",
"files": [
{
"path": "types/mailchimp__mailchimp_marketing/index.d.ts",
"kind": "definition"
},
{
"path": "types/mailchimp__mailchimp_marketing/mailchimp__mailchimp_marketing-tests.ts",
"kind": "test"
}
],
"owners": [
"rattkin",
"jeremybarbet",
"odanieldcs",
"edwinfinch"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 2107239052,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/0108547106feecafa39fe09f4a54812142563458/checks?check_suite_id=23716498744"
} |
🔔 @rattkin @jeremybarbet @odanieldcs @edwinfinch — please review this PR in the next few days. Be sure to explicitly select |
@ExTBH The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
@ExTBH I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Jun 12th (in a week) if the issues aren't addressed. |
searchMembers.search can have optional parameters as per the docs https://mailchimp.com/developer/marketing/api/search-members/search-members/
Please fill in this template.
pnpm test <package to test>
.If changing an existing definition:
package.json
.