-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cytoscape] Fixes typing of arguments to concentric, levelWidth callbacks #69591
base: master
Are you sure you want to change the base?
[cytoscape] Fixes typing of arguments to concentric, levelWidth callbacks #69591
Conversation
ConcentricLayoutOptions can include two callbacks that are invoked with a single node and all nodes in the layout respectively. The previous typing was based on the example use in the documentation and prevented use of other node properties to be accessed.
@cneumann Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69591,
"author": "cneumann",
"headCommitOid": "278d86f040b5986c61dadf76b38054c8707ad8b1",
"mergeBaseOid": "35ea3e696d3fb324ce0c779d20c2ab83f36d9181",
"lastPushDate": "2024-05-13T15:09:19.000Z",
"lastActivityDate": "2024-05-31T21:03:30.000Z",
"mergeOfferDate": "2024-05-31T21:04:06.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "cytoscape",
"kind": "edit",
"files": [
{
"path": "types/cytoscape/cytoscape-tests.ts",
"kind": "test"
},
{
"path": "types/cytoscape/index.d.ts",
"kind": "definition"
}
],
"owners": [
"phreed",
"wy193777",
"ypconstante",
"janniclas",
"gsbelarus",
"peterjferrarotto",
"spaxe",
"Veckodag",
"jsve",
"rogerdubbs"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "sheetalkamat",
"date": "2024-05-31T21:03:30.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2107929298,
"ciResult": "pass"
} |
🔔 @phreed @wy193777 @ypconstante @janniclas @gsbelarus @PeterJFerrarotto @Spaxe @Veckodag @jsve @rogerdubbs — please review this PR in the next few days. Be sure to explicitly select |
Re-ping @phreed, @wy193777, @ypconstante, @janniclas, @gsbelarus, @PeterJFerrarotto, @Spaxe, @Veckodag, @jsve, @rogerdubbs: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @cneumann. (Ping @phreed, @wy193777, @ypconstante, @janniclas, @gsbelarus, @PeterJFerrarotto, @Spaxe, @Veckodag, @jsve, @rogerdubbs.) |
@cneumann: Everything looks good here. I am ready to merge this PR (at 278d86f) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@phreed, @wy193777, @ypconstante, @janniclas, @gsbelarus, @PeterJFerrarotto, @Spaxe, @Veckodag, @jsve, @rogerdubbs: you can do this too.) |
ConcentricLayoutOptions can include two callbacks that are invoked with a single node and all nodes in the layout respectively. The previous typing was based on the example use in the documentation and prevented use of other node properties to be accessed.
Please fill in this template.
pnpm test <package to test>
.If changing an existing definition:
concentric
callback with node argument, call tolevelWidth
callback with all nodes as argument.package.json
.