-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type definitions for node-fork.js: Node fork chess package #69630
base: master
Are you sure you want to change the base?
Conversation
feat: adding type declarations for node-fork.js package
chore: adding necessary comments
@sah246ir Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 26 days — it is considered nearly abandoned! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69630,
"author": "sah246ir",
"headCommitOid": "2bbf718fc5d83efeb5d4cde51ace41919fe60236",
"mergeBaseOid": "acac6a1f25ff44f786b1f21216fb55d0699b7dd3",
"lastPushDate": "2024-05-17T12:30:43.000Z",
"lastActivityDate": "2024-05-17T12:30:43.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "node-fork.js",
"kind": "add",
"files": [
{
"path": "types/node-fork.js/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/node-fork.js/index.d.ts",
"kind": "definition"
},
{
"path": "types/node-fork.js/node-fork.js-tests.ts",
"kind": "test"
},
{
"path": "types/node-fork.js/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/node-fork.js/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 2117495460,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/2bbf718fc5d83efeb5d4cde51ace41919fe60236/checks?check_suite_id=23922608544"
} |
🔔 @sah246ir — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
@sah246ir The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
@sah246ir The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
@sah246ir The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
@sah246ir The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
@sah246ir The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
@sah246ir The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
@sah246ir I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Jun 16th (in a week) if the issues aren't addressed. |
No description provided.