-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@types/k6): exact optional property type mismatch #69636
base: master
Are you sure you want to change the base?
Conversation
The provided type did not compile when `exactOptionalPropertyTypes` is configured. This commit resolves the compiler error encountered when compiling in this mode.
@wuhkuh Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 25 days — it is still unreviewed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69636,
"author": "wuhkuh",
"headCommitOid": "aaf2e9157676f34a3191f24bdfcd7793ef22e305",
"mergeBaseOid": "acac6a1f25ff44f786b1f21216fb55d0699b7dd3",
"lastPushDate": "2024-05-18T10:07:10.000Z",
"lastActivityDate": "2024-05-28T19:47:11.000Z",
"maintainerBlessed": "Waiting for Code Reviews",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "k6",
"kind": "edit",
"files": [
{
"path": "types/k6/http.d.ts",
"kind": "definition"
}
],
"owners": [
"MStoykov",
"codebien",
"oleiade",
"olegbespalov",
"nicolevanderhoeven",
"ankur22",
"inancgumus",
"ka3de",
"joanlopez"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [],
"mainBotCommentID": 2118757576,
"ciResult": "pass"
} |
Hey @wuhkuh, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
🔔 @mstoykov @codebien @oleiade @olegbespalov @nicolevanderhoeven @ankur22 @inancgumus @ka3de @joanlopez — please review this PR in the next few days. Be sure to explicitly select |
Re-ping @mstoykov, @codebien, @oleiade, @olegbespalov, @nicolevanderhoeven, @ankur22, @inancgumus, @ka3de, @joanlopez: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @wuhkuh. (Ping @mstoykov, @codebien, @oleiade, @olegbespalov, @nicolevanderhoeven, @ankur22, @inancgumus, @ka3de, @joanlopez.) |
The provided type did not compile when
exactOptionalPropertyTypes
is configured. This commit resolves the compiler error encountered when compiling in this mode.Please fill in this template.
pnpm test <package to test>
.If changing an existing definition:
package.json
.I can't seem to get the packages tested individually (my Node+TS setup is segfaulting since a recent upgrade).
So I'll try to rely on CI to test my changes; my goal here is to make my local patch available to the repository, no strings attached.
Do note that Node's types also had this typing problem a while ago.
I opted for this solution to not break the signature of the typing library, but there are other solutions, too, such as allowing explicit
undefined
s in the extended types.