Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript definitions for react-native-progress-steps #69640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ugur-Atakan
Copy link

Add TypeScript definitions for react-native-progress-steps

@typescript-bot
Copy link
Contributor

typescript-bot commented May 18, 2024

@Ugur-Atakan Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ❌ Continuous integration tests have failed
  • 🕐 Only a DT maintainer can approve changes when there are new packages added

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 25 days — it is considered nearly abandoned!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69640,
  "author": "Ugur-Atakan",
  "headCommitOid": "ba5773894a8f9426b9173949aef6a4598e3dbd0d",
  "mergeBaseOid": "18bf370503e2feaf5169bb64a934ffcddf98cbc3",
  "lastPushDate": "2024-05-18T18:08:26.000Z",
  "lastActivityDate": "2024-05-18T18:08:26.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "react-native-progress-steps",
      "kind": "add",
      "files": [
        {
          "path": "types/react-native-progress-steps/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-native-progress-steps/tsconfig.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.types`, `compilerOptions.strictNullChecks`, `compilerOptions.strictFunctionTypes`, `compilerOptions.noImplicitThis`, `compilerOptions.noImplicitAny`, `compilerOptions.strict`)"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2118904975,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/ba5773894a8f9426b9173949aef6a4598e3dbd0d/checks?check_suite_id=23929785848"
}

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Untested Change This PR does not touch tests Check Config Changes a module config files labels May 18, 2024
@typescript-bot
Copy link
Contributor

Hey @Ugur-Atakan,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 18, 2024
@typescript-bot
Copy link
Contributor

🔔 @Ugur-Atakan — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label May 18, 2024
@typescript-bot
Copy link
Contributor

@Ugur-Atakan The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board May 18, 2024
@typescript-bot
Copy link
Contributor

@Ugur-Atakan I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Jun 17th (in a week) if the issues aren't addressed.

@typescript-bot typescript-bot added the Abandoned This PR had no activity for a long time, and is considered abandoned label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abandoned This PR had no activity for a long time, and is considered abandoned Check Config Changes a module config files New Definition This PR creates a new definition package. The CI failed When GH Actions fails Untested Change This PR does not touch tests
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants