Skip filesystem shrinking without error if it's already right-sized #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a case handed to me by a user of your script where I observed the following:
The image was 60 GB large but only had a 0.5 GB fat32 partition and an 5.81 GB ext4 partition. Maybe the image was not expanded after being moved before, I don't know. The
resize2fsestimate was that the filesystem could not be shrunk so the whole script errored out with error 11.The filesystem already being right-sized is not inherently an unrecoverable error. We can continue the process anyway and proceed with shrinking partitions and truncating the file. That's all that my change does, replaces the error by a branch and changes some log messages to indicate the behaviour.