Collect cum logs under their own heading #197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't this be |
spetravic
reviewed
Mar 27, 2024
Comment on lines
+56
to
59
| k_split[0] = f"cumulative/{k_split[0]}_{suffix}" | ||
| k = "/".join(k_split) | ||
|
|
||
| self._writer.add_scalar(f"{k}/cumulative", v, bp_step) |
There was a problem hiding this comment.
We could do "cumulative/{k}" when adding the scalar instead to avoid the duplication
There was a problem hiding this comment.
I made it redundant so it would be easy to exclude when you search for it. But I am happy to skip it.
|
@docubot Please document |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rarely need the cumulative logs, but when they are needed it's really good to have. I have therefore hidden them all under a common
cumulative/heading in tb.