Fixed the theme loader as to work when <head> isn't yet created #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small pull request fixes the theme loader so it waits until the window fires the event
DOMContentLoadedIt also makes it so the two
<link>elements are now refered to with an id (using theimproved_intra__<NAME>as to never conflict with other ids). This allows the use of a "getter" and to only create the element if it doesn't exist.the next step should be to unconditionally create such elements, and just remove the
hrefelement (or maybe point to an empty css file ?)This would allow it to not dance around creating new elements and remove the if needed.
This pull request also include a very minor change to
build.sh(chaning the shbang to/usr/bin/env bashas to work on my nixos machine.) This should have no effect whatsoever for other distribution.