Reuse VM memory across executions #1888
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voxelot
reviewed
May 8, 2024
| pub(crate) fn get_vm_memory() -> Memory { | ||
| POOL.with(|pool| { | ||
| let mut pool = pool.borrow_mut(); | ||
| pool.pop().unwrap_or_else(Memory::new) |
There was a problem hiding this comment.
We should probably have some kind constraint on the max number of items allowed in each pool? Otherwise it should wait if there are none available.
There was a problem hiding this comment.
We didn't do this earlier, and I don't see why it would make sense to track the items here, instead of just limiting concurrency of the executor itself. That said, keeping a pool per thread is by itself problematic and not useful, as:
- The threads are not CPU-pinned anyway
- The async runtime might decide to create new threads arbitarily, which would essentially cause a memory leak here
So I' changed the code to not keep separate pools in 5caec42
MitchTurner
reviewed
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1878. Requires FuelLabs/fuel-vm#732 and a new fuel-vm release.
Introduces a per-thread pool for allocated VM memory instances. Whenever a new VM instance is needed for a tx, the memory is taken from this pool. After the tx has been executed, the memory is reset to an empty state without deallocating, and returned to the pool.
A per-thread pool was chosen to no pass allocations between threads unnecessarily.
Checklist
Before requesting review