-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds method and function deduplication to frontend. #5967
Draft
esdrubal
wants to merge
3
commits into
master
Choose a base branch
from
esdrubal/5904_method_dedup_in_frontend
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esdrubal
added
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
performance
Everything related to performance, speed wise or memory wise.
labels
May 6, 2024
esdrubal
force-pushed
the
esdrubal/5904_method_dedup_in_frontend
branch
from
May 6, 2024 15:55
8e67524
to
1b48780
Compare
Benchmark for 137c576Click to view benchmark
|
Adds function cached to query engine, and reuses previously compiled methods and functions. Closes #5904.
esdrubal
force-pushed
the
esdrubal/5904_method_dedup_in_frontend
branch
from
May 20, 2024 13:40
1b48780
to
c809b9a
Compare
Benchmark for b7a8502Click to view benchmark
|
Benchmark for de6c896Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
performance
Everything related to performance, speed wise or memory wise.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds function cached to query engine, and reuses previously compiled methods and functions.
Closes #5904.
Checklist
Breaking*
orNew Feature
labels where relevant.