Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github_runner_matrix: define timeout values in constants #17280

Merged
merged 1 commit into from
May 27, 2024
Merged

github_runner_matrix: define timeout values in constants #17280

merged 1 commit into from
May 27, 2024
+8 −5

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented May 11, 2024 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This allows us to keep all information about timeout values here in
brew instead of both here and in Homebrew/core.

Needed for Homebrew/homebrew-core#171457.

@carlocab carlocab mentioned this pull request May 11, 2024
Merged
@carlocab
github_runner_matrix: define timeout values in constants
a9c8556 
This allows us to keep all information about timeout values here in
`brew` instead of both here and in Homebrew/core.

Will be needed after Homebrew/homebrew-core#171457.
@carlocab carlocab marked this pull request as ready for review May 11, 2024 20:48
MikeMcQuaid
MikeMcQuaid approved these changes May 12, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, love DRYing things up.

@carlocab carlocab merged commit ff83a4f into master May 27, 2024
25 checks passed
@carlocab carlocab deleted the timeout-values branch May 27, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carlocab @MikeMcQuaid