Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glances 4.0.5 #171483

Merged
merged 2 commits into from
May 19, 2024
Merged

glances 4.0.5 #171483

merged 2 commits into from
May 19, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels May 12, 2024
@SMillerDev
Copy link
Member

  Traceback (most recent call last):
    File "/home/linuxbrew/.linuxbrew/Cellar/glances/4.0.0/bin/glances", line 8, in <module>
      sys.exit(main())
               ^^^^^^
    File "/home/linuxbrew/.linuxbrew/Cellar/glances/4.0.0/libexec/lib/python3.12/site-packages/glances/__init__.py", line 184, in main
      start(config=core.get_config(), args=core.get_args())
    File "/home/linuxbrew/.linuxbrew/Cellar/glances/4.0.0/libexec/lib/python3.12/site-packages/glances/__init__.py", line 94, in start
      from glances.standalone import GlancesStandalone as GlancesMode
    File "/home/linuxbrew/.linuxbrew/Cellar/glances/4.0.0/libexec/lib/python3.12/site-packages/glances/standalone.py", line 20, in <module>
      from glances.outputs.glances_curses import GlancesCursesStandalone
    File "/home/linuxbrew/.linuxbrew/Cellar/glances/4.0.0/libexec/lib/python3.12/site-packages/glances/outputs/glances_curses.py", line 18, in <module>
      from glances.events_list import glances_events
    File "/home/linuxbrew/.linuxbrew/Cellar/glances/4.0.0/libexec/lib/python3.12/site-packages/glances/events_list.py", line 14, in <module>
      from pydantic import RootModel
  ModuleNotFoundError: No module named 'pydantic'

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label May 12, 2024
@chenrui333 chenrui333 force-pushed the bump-glances-4.0.0 branch 2 times, most recently from ffc9abc to 2159534 Compare May 12, 2024 16:57
@SMillerDev
Copy link
Member

SMillerDev commented May 12, 2024

This looks like pydantic should be a formula. Otherwise all Python formula will end up with a rust dependency

@chenrui333 chenrui333 removed the automerge-skip `brew pr-automerge` will skip this pull request label May 12, 2024
@chenrui333
Copy link
Member

chenrui333 commented May 12, 2024

This looks like pydantic should be a formula. Do not ask Python formula will end up with a rust dependency

I feel the same too, but it is a bit complicated. pydantic and pydantic_core both have rust deps. cc @branchvincent @Homebrew/core for thoughts

@chenrui333 chenrui333 changed the title glances 4.0.0 glances 4.0.1 May 12, 2024
@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label May 12, 2024
@chenrui333
Copy link
Member

On second thoughts, yeah, I guess we can move pydantic into the formula as pydantic-core is the dependant. 👍

@chenrui333 chenrui333 added the upstream issue An upstream issue report is needed label May 12, 2024
@chenrui333 chenrui333 changed the title glances 4.0.1 glances 4.0.2 May 14, 2024
@chenrui333
Copy link
Member

rebase per nicolargo/glances#2761

@chenrui333 chenrui333 added CI-requeued PR has been re-added to the queue and removed upstream issue An upstream issue report is needed labels May 14, 2024
@chenrui333 chenrui333 changed the title glances 4.0.2 glances 4.0.4 May 15, 2024
@carlocab
Copy link
Member

This looks like pydantic should be a formula. Otherwise all Python formula will end up with a rust dependency

Not opposed to this

@woodruffw
Copy link
Member

+1 from me -- this is consistent with the precedent around python-cryptography and other Rust deps for Python 🙂

@MikeMcQuaid
Copy link
Member

and me 👍🏻

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label May 19, 2024
Signed-off-by: Rui Chen <rui@chenrui.dev>

Co-authored-by: Sean Molenaar <sean@seanmolenaar.eu>
@branchvincent branchvincent changed the title glances 4.0.4 glances 4.0.5 May 19, 2024
@github-actions github-actions bot removed the rust Rust use is a significant feature of the PR or issue label May 19, 2024
@branchvincent branchvincent removed the stale No recent activity label May 19, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 19, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 19, 2024
Merged via the queue into master with commit e33ec7f May 19, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the bump-glances-4.0.0 branch May 19, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-requeued PR has been re-added to the queue python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants