libnghttp2 nghttp2 1.62.1

[bevanjkay]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[bevanjkay]

Upstream issue for GCC11 build failure on Linux - nghttp2/nghttp2#2194

I'm not sure that I have the correct combination of fails_with.

Missing runtime dependency in latest linux CI run

 /home/linuxbrew/.linuxbrew/Cellar/nghttp2/1.62.1/bin/nghttp: /lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.32' not found (required by /home/linuxbrew/.linuxbrew/Cellar/nghttp2/1.62.1/bin/nghttp)

[carlocab]

I think the test failure is because we're mixing different compiler versions between libnghttp2 and nghttp2.

But either of them failing with the host compiler is a huge problem. CC @Homebrew/core for thoughts.

[Bo98]

Adding a dependency with libnghttp2 would have massive effects on the dependency tree of homebrew-core as a whole so wouldn't really be acceptable without discussion.

There may also concern even for older Clang. If libnghttp2 is broken on older Clang, we must drop support for macOS 10.11 in Homebrew/brew.

However, it seems like libnghttp2 might be ok though which is interesting. Are we only hitting the issue with the nghttp2 executables? That's less of an issue and generally should work OK even though libnghttp2 use an older GCC.

[carlocab]

That's less of an issue and generally should work OK even though libnghttp2 use an older GCC.

I'd have thought we'd be ok using a newer GCC only for nghttp2 and not libnghttp2, but the test block disagrees, unfortunately.

[cho-m]

That's less of an issue and generally should work OK even though libnghttp2 use an older GCC.

I'd have thought we'd be ok using a newer GCC only for nghttp2 and not libnghttp2, but the test block disagrees, unfortunately.

Can try adding Formula["gcc@13"].opt_lib/"gcc/13" to RPATH. Not sure if it will precede #{HOMEBREW_PREFIX}/lib/gcc/current (otherwise may have some extra missing linkage reports whenever brew gcc is installed on CI).

---

EDIT: Though we may want to wait for upstream response if they will support GCC 11 given it is commonly used in LTS distros.

[MikeMcQuaid]

Adding a dependency with libnghttp2 would have massive effects on the dependency tree of homebrew-core as a whole so wouldn't really be acceptable without discussion.

Is this just on Linux?

If libnghttp2 is broken on older Clang, we must drop support for macOS 10.11 in Homebrew/brew.

Why is that, can you elaborate?

[Bo98]

I'd have thought we'd be ok using a newer GCC only for nghttp2 and not libnghttp2, but the test block disagrees, unfortunately.

libnghttp2 shouldn't be using C++:

Compiling libnghttp2 C source code requires a C99 compiler. gcc 4.8 is known to be adequate. In order to compile the C++ source code, C++20 compliant compiler is required. At least g++ >= 1.12 and clang++ >= 1.15 are known to work.

Is this just on Linux?
Why is that, can you elaborate?

Because it's a dependency for curl, and we require brewed curl on older macOS.

[carlocab]

Actually, compiling nghttp2 (and not libnghttp2) with Homebrew gcc should just work. It'll fail the Linux-only GCC dependency audit, though.

[MikeMcQuaid]

Because it's a dependency for curl, and we require brewed curl on older macOS.

Gotcha, thanks. Yeh, I think it'd either be: drop it as a dependency, drop it as a dependency on old macOS versions (dangerous with no CI coverage) or drop those macOS versions.

It'll fail the Linux-only GCC dependency audit, though.

Seems like a good case to opt-out of.

[carlocab]

Let's see if using gcc does indeed work before we add an audit opt-out... dbded26

[carlocab]

Ok, that works. Homebrew/brew#17384

[MikeMcQuaid]

What macOs version does this correspond to?

[MikeMcQuaid]

Adding a dependency with libnghttp2 would have massive effects on the dependency tree of homebrew-core as a whole so wouldn't really be acceptable without discussion.

Is this just on Linux?

If libnghttp2 is broken on older Clang, we must drop support for macOS 10.11 in Homebrew/brew.

Why is that, can you elaborate?