Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sherlock 0.14.3 (new formula) #171701

Merged
merged 2 commits into from
May 15, 2024
Merged

sherlock 0.14.3 (new formula) #171701

merged 2 commits into from
May 15, 2024

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core autobump labels May 14, 2024
@chenrui333
Copy link
Member

better to use numpy formula?

@p-linnane
Copy link
Member Author

better to use numpy formula?

Good call. Done.

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 14, 2024
@p-linnane p-linnane removed the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 14, 2024
@p-linnane p-linnane mentioned this pull request May 14, 2024
Open
@p-linnane p-linnane removed the automerge-skip `brew pr-automerge` will skip this pull request label May 15, 2024
@chenrui333 chenrui333 mentioned this pull request May 15, 2024
Merged
@p-linnane
sherlock 0.14.3 (new formula)
ca9c915 
Signed-off-by: Patrick Linnane <patrick@linnane.io>
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label May 15, 2024
@p-linnane p-linnane removed the automerge-skip `brew pr-automerge` will skip this pull request label May 15, 2024
@carlocab carlocab mentioned this pull request May 15, 2024
Closed
3 tasks
@github-actions GitHub Actions
Copy link
Contributor

:shipit: @p-linnane has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 15, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 15, 2024
Merged via the queue into master with commit 89bf906 May 15, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the sherlock-add-formula branch May 15, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@branchvincent branchvincent branchvincent left review comments

@Bo98 Bo98 Bo98 approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
autobump CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@p-linnane @chenrui333 @Bo98 @branchvincent @BrewTestBot