Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes-cli@1.29 1.29.4 (new formula) #171733

Merged
merged 2 commits into from
May 15, 2024

Conversation

rrotter
Copy link
Contributor

@rrotter rrotter commented May 15, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core legacy Relates to a versioned @ formula formula disabled Formula disabled labels May 15, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label May 15, 2024
@rrotter
Copy link
Contributor Author

rrotter commented May 15, 2024

I thought I was doing the right thing by including the EOL in the formula. Should that be a !deprecate rather than !disable? I can't figure out what the pattern is from looking at other versioned formulae (e.g. ruby@2.7 and ruby@3.0).

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SMillerDev
Copy link
Member

I thought I was doing the right thing by including the EOL in the formula.

You did!

@SMillerDev SMillerDev added this pull request to the merge queue May 15, 2024
Merged via the queue into Homebrew:master with commit 24ac24b May 15, 2024
23 checks passed
@rrotter
Copy link
Contributor Author

rrotter commented May 15, 2024

Thanks. It doesn't look like BrewTestBot is picking this up to create the bottles. Is there something I should have added in the formula? Maybe it's not getting built because of the inclusion of the !disable date?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request formula disabled Formula disabled go Go use is a significant feature of the PR or issue legacy Relates to a versioned @ formula new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants