Add additional events for StreamingPayments #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area
force-pushed
the
feat/streatming-events
branch
from
a41b32a
to
98d61ff
Compare
area
force-pushed
the
feat/streatming-events
branch
from
98d61ff
to
a41b32a
Compare
area
force-pushed
the
maint/pnpm
branch
6 times, most recently
from
e46dff7
to
68470db
Compare
|
Can we close this in favor of #1250 ? |
|
No, this commit is currently being used on the Dapp side, and #1250 is based on the PNPM work. |
area
force-pushed
the
feat/streatming-events
branch
from
a41b32a
to
f7a76e0
Compare
kronosapiens
previously approved these changes
May 22, 2024
kronosapiens
force-pushed
the
feat/streatming-events
branch
from
f7a76e0
to
482296d
Compare
area
force-pushed
the
feat/streatming-events
branch
2 times, most recently
from
e6325ed
to
fdd1351
Compare
area
force-pushed
the
feat/streatming-events
branch
2 times, most recently
from
aae67d3
to
c9520e7
Compare
kronosapiens
approved these changes
May 29, 2024
area
force-pushed
the
feat/streatming-events
branch
from
c9520e7
to
f176cdb
Compare
area
force-pushed
the
feat/streatming-events
branch
from
f176cdb
to
656bd34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional events after discussing with Jakub about requirements for the implementation of streaming payments.
Currently a draft, not to be merged, until we've straightened everything out with the Arbitrum deployment branches, but will unblock development on the CDApp side until then.