-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump hardhat to 2.22 #1254
base: develop
Are you sure you want to change the base?
Bump hardhat to 2.22 #1254
Conversation
905c47b
to
6181c43
Compare
529bfe9
to
5271c41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make arguments to getMetatransactionNonce consistent among contracts
If this is the goal, then I believe you have missed:
- ColonyNetworkAuction
- IBasicMetaTransaction
- CoinMachine
- FundingQueue
- TokenSupplier
- Whitelist
- VotingReputationStorage
- VotingReputationMisaligned
- TokenLocking
Did you not touch incrementMetatransactionNonce
because it's internal, or some other reason?
Fun to see a refactor that reduces duplication to the extent the coverage thresholds fail so more tests have to be written, that's good to see 😄
63a8b23
to
1c3d108
Compare
Thinking about this more, I'm not sure if there's much benefit to including
I say this because we already have a If anything, the UPDATE: after discussing with @area we will delete both |
913f7ad
to
55f3ef7
Compare
041303f
to
63f1a19
Compare
63f1a19
to
7782d46
Compare
6e56327
to
20e8db9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TokenLocking, VotingReputationMisaligned have still not had their metatransaction arguments updated.
69fa350
to
0c856d8
Compare
60fbf5c
to
2abfef3
Compare
2abfef3
to
dc8ddc7
Compare
dc8ddc7
to
b7584d6
Compare
Closes #1228
Main
cancun
hardforkselfdestruct
and update uninstall behavior for extensionsColonyExtension.sol
base class and remove boilerplate from extension contractsMisc
reputation-test-non-gnosis
Circle job to reduce total build timesgetMetatransactionNonce
consistent among affected contracts