Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): all general commands are implemented #1932

Open
wants to merge 356 commits into
base: dev
Choose a base branch
from

Conversation

rozhkovdmitrii
Copy link

@rozhkovdmitrii rozhkovdmitrii commented Aug 4, 2023

This PR introduces the most of commands provided by both Legacy and 2.0 versions of Komodo DeFi framework RPC API that were not introduced in the earlier versions:

swap: active_swaps, my_swap_status, my_recent_swaps, min_trading_vol, max_taker_vol,
network: get_gossip_mesh, get_gossip_peer_topics, get_gossip_topic_peers, get_my_peer_id, get_peers_info, get_relay_mesh
coin: disable_coin, set_required_confirmations, set_requires_notarization, coins_needed_for_kick_start
utility: get_current_mtp, ban_pubkey, list_banned_pubkeys, unban_pubkeys
wallet: show_priv_key, validate_address, kmd_rewards_info
convertaddress, convert_utxo_address, tx_history, sign_message, verify_message, send_raw_transaction, withdraw (v2), get_raw_transaction, get_public_key, get_public_key_hash,
enable: enable_bch_with_tokens, - enable_slp, enable_tendermint_with_assets, enable_tendermint_token, enable_eth_with_tokens, enable_erc20, task_enable_z_coin_init, task_enable_z_coin_status, task_enable_z_coin_cancel
version stat: add_node_to_version_stat, remove_node_from_version_stat, start_version_stat_collection, stop_version_stat_collection, update_version_stat_collection

Dependency Updates:

komodefi-cli

Package From To mm2
addr2line 0.19.0 0.17.0 0.17.0
aho-corasick 1.0.1 0.7.18 0.7.18
allocator-api2 0.2.15 0.2.16
anstyle 1.0.0 1.0.1
anstyle-parse 0.2.0 0.2.1
anstyle-wincon 1.0.1 1.0.2
anyhow 1.0.71 1.0.42 1.0.42
arrayvec 0.7.2 0.7.1 0.7.1
async-trait 0.1.68 0.1.52 0.1.52
backtrace 0.3.67 0.3.66 0.3.66
blake2b_simd 0.5.11 0.5.10 0.5.10
bumpalo 3.12.2 3.12.0 3.12.0
cc 1.0.79 1.0.74 1.0.74
chrono 0.4.24 0.4.23 0.4.23
clap 4.3.4 4.2.7 2.33.3
clap_builder 4.3.4 4.2.7
clap_derive 4.3.2 4.2.0
clap_lex 0.5.0 0.4.1
cpufeatures 0.2.7 0.2.1 0.2.1
crossbeam-epoch 0.9.14 0.9.5 0.9.5
crossbeam-utils 0.8.15 0.8.8 0.8.8
crossterm_winapi 0.9.0 0.9.1
cxx 1.0.94 1.0.81 1.0.81
cxx-build 1.0.94 1.0.62 1.0.62
cxxbridge-flags 1.0.94 1.0.81 1.0.81
cxxbridge-macro 1.0.94 1.0.81 1.0.81
derive_more 0.99.17 0.99.11 0.99.11
dyn-clone 1.0.11 1.0.12
either 1.8.1 1.6.0 1.6.0
errno 0.3.1 0.3.2 0.2.8
gimli 0.27.2 0.26.2 0.26.2
h2 0.3.18 0.3.19 0.3.19
hermit-abi 0.1.14, 0.3.1 0.1.14, 0.3.2 0.1.14
hyper-rustls 0.23.2 0.23.0 0.23.0
iana-time-zone 0.1.56 0.1.53 0.1.53
ipnet 2.7.2 2.3.0 2.3.0
is-terminal 0.4.7 0.4.9
itoa 1.0.6 1.0.1 1.0.1
js-sys 0.3.57 0.3.55 0.3.55
libc 0.2.144 0.2.139 0.2.139
lightning-invoice NEW 0.21.0
link-cplusplus 1.0.8 1.0.7 1.0.7
linux-raw-sys 0.3.8 0.4.5 0.1.4
lock_api 0.4.9 0.4.6 0.4.6
memoffset 0.8.0 0.6.4 0.6.4
metrics 0.21.0 0.21.1 0.21.1
num_cpus 1.15.0 1.13.1 1.13.1
object 0.30.3 0.29.0 0.29.0
once_cell 1.17.1 1.16.0 1.16.0
parity-scale-codec 3.5.0 3.1.2 3.1.2
parity-scale-codec-derive 3.1.4 3.1.2
parking_lot 0.12.1 0.12.0 0.12.0
parking_lot_core 0.9.7 0.9.1 0.9.1
paste 1.0.12 1.0.7 1.0.7
portable-atomic 1.3.3 1.3.2 1.3.2
proc-macro-crate 1.3.1 1.1.3 1.1.3
proc-macro2 1.0.56 1.0.58 1.0.58
redox_syscall 0.2.16 0.2.10
redox_users 0.4.3 0.4.0
regex 1.8.1 1.5.6 1.5.6
regex-syntax 0.7.1 0.6.26 0.6.26
rustc_version 0.4.0 0.2.3 0.2.3
rustix 0.37.20 0.38.8 0.36.9
ryu 1.0.13 1.0.5 1.05
scratch 1.0.5 1.0.2 1.0.2
security-framework 2.9.1 2.9.2
security-framework-sys 2.9.0 2.9.1
semver 1.0.17 0.9.0 0.9.0
serde 1.0.163 1.0.164 1.0.164
serde_derive 1.0.163 1.0.164 1.0.164
serde_json 1.0.96 1.0.79 1.0.79
serde_repr 0.1.12 0.1.6 0.1.6
signal-hook 0.3.15 0.3.17
smallvec 1.10.0 1.6.1 1.6.1
syn 2.0.15 2.0.16 2.0.16
term-table NEW 1.3.2
thiserror 1.0.40 1.0.30 1.0.30
thiserror-impl 1.0.40 1.0.30 1.0.30
tokio 1.28.1 1.25.0 1.25.0
tokio-macros 2.1.0 1.7.0 1.7.0
toml NEW 0.5.7
tracing 0.1.37 0.1.34 0.1.34
tracing-attributes 0.1.24 0.1.20 0.1.20
tracing-core 0.1.30 0.1.26 0.1.26
unicode-ident 1.0.8 1.0.0 1.0.0
uuid 1.3.2 1.2.2 1.2.2
wasm-bindgen-futures 0.4.30 0.4.21 0.4.21
wasm-bindgen-test 0.3.30 0.3.13 0.3.13
wasm-bindgen-test-macro 0.3.30 0.3.13 0.3.13
web-sys 0.3.57 0.3.55 0.3.55
windows-targets 0.48.0 0.48.1 0.42.1

rozhkovdmitrii and others added 30 commits June 26, 2023 19:51
# Conflicts:
#	mm2src/adex_cli/src/adex_app.rs
#	mm2src/adex_cli/src/adex_proc/adex_proc_impl.rs
#	mm2src/adex_cli/src/adex_proc/command.rs
#	mm2src/adex_cli/src/adex_proc/response_handler.rs
#	mm2src/adex_cli/src/adex_proc/response_handler/orderbook.rs
Signed-off-by: borngraced <samuelonoja970@gmail.com>
onur-ozkan
onur-ozkan previously approved these changes Dec 5, 2023
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@shamardy shamardy self-requested a review December 5, 2023 18:12
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for the fixes @borngraced! Have some minor comments/questions.

mm2src/komodefi_cli/src/cli_cmd_args/cmd_set_config.rs Outdated Show resolved Hide resolved
mm2src/komodefi_cli/src/cli_cmd_args/cmd_set_config.rs Outdated Show resolved Hide resolved
mm2src/komodefi_cli/src/config.rs Outdated Show resolved Hide resolved
Signed-off-by: borngraced <samuelonoja970@gmail.com>
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes! Last comments from my side!

mm2src/komodefi_cli/Cargo.lock Show resolved Hide resolved
mm2src/komodefi_cli/Cargo.lock Show resolved Hide resolved
Signed-off-by: borngraced <samuelonoja970@gmail.com>
Signed-off-by: borngraced <samuelonoja970@gmail.com>
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes! Only one minor comment!
I think we should update the deps table here #1932 (comment), remove from the table any row with a dep that is the same as mm2 and only add the ones that are different or new to the table.

mm2src/derives/skip_serializing_none/src/lib.rs Outdated Show resolved Hide resolved
Signed-off-by: borngraced <samuelonoja970@gmail.com>
shamardy
shamardy previously approved these changes Dec 19, 2023
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@shamardy
Copy link
Collaborator

@smk762 can you please check if your comments here #1932 (comment) are resolved?

# Conflicts:
#	mm2src/coins/eth.rs
#	mm2src/coins/lightning.rs
#	mm2src/coins/lp_coins.rs
#	mm2src/coins/qrc20.rs
#	mm2src/coins/solana.rs
#	mm2src/coins/solana/spl.rs
#	mm2src/coins/tendermint/tendermint_coin.rs
#	mm2src/coins/tendermint/tendermint_token.rs
#	mm2src/coins/utxo.rs
#	mm2src/coins/utxo/bch.rs
#	mm2src/coins/utxo/slp.rs
#	mm2src/coins/utxo/utxo_common.rs
#	mm2src/coins/z_coin.rs
Signed-off-by: borngraced <samuelonoja970@gmail.com>
borngraced and others added 2 commits December 21, 2023 02:35
Signed-off-by: borngraced <samuelonoja970@gmail.com>
ca333
ca333 previously approved these changes Feb 13, 2024
Copy link

@ca333 ca333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completed secure code review / plz re-evaluate integration status / overall arch/mm2 impact. (e.g. we might want to further modularize/enhance the cli prior to propagating it to dev/main)

smk762
smk762 previously approved these changes Feb 15, 2024
Copy link

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All requests in #1932 (comment) have been resolved, thanks!

# Conflicts:
#	mm2src/komodefi_cli/Cargo.lock
#	mm2src/mm2_main/src/rpc/dispatcher/dispatcher.rs
@borngraced borngraced dismissed stale reviews from smk762 and ca333 via 1c7697f February 15, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants