Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(solana-swap): solana swap protocol v1 POC #2091

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from
Open

Conversation

r2st
Copy link

@r2st r2st commented Mar 27, 2024

Implementation of the following SwapOps trait methods for SolanaCoin in the defi framework:

  • send_maker_payment
  • send_taker_spends_maker_payment
  • send_maker_refunds_payment

Test cases for:

  • send and spend
  • send and refund

@r2st r2st changed the title feat(solana-swap):solana swap protocol v1 POC feat(solana-swap):solana swap protocol v1 POC - progress Mar 27, 2024
@r2st r2st changed the title feat(solana-swap):solana swap protocol v1 POC - progress feat(solana-swap):solana swap protocol v1 POC - in progress Mar 27, 2024
@shamardy shamardy changed the title feat(solana-swap):solana swap protocol v1 POC - in progress feat(solana-swap):solana swap protocol v1 POC Mar 27, 2024
@shamardy shamardy added the in progress Changes will be made from the author label Mar 27, 2024
@shamardy shamardy changed the title feat(solana-swap):solana swap protocol v1 POC feat(solana-swap): solana swap protocol v1 POC Mar 27, 2024
@shamardy shamardy added under review and removed in progress Changes will be made from the author labels Mar 29, 2024
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! This is the first review iteration concerned with cleaning up the code a bit so I can easily review it.

mm2src/coins/solana.rs Outdated Show resolved Hide resolved
mm2src/coins/solana.rs Outdated Show resolved Hide resolved
mm2src/coins/solana.rs Outdated Show resolved Hide resolved
mm2src/coins/solana.rs Outdated Show resolved Hide resolved
mm2src/coins/solana.rs Outdated Show resolved Hide resolved
mm2src/coins/solana.rs Outdated Show resolved Hide resolved
mm2src/coins/solana.rs Outdated Show resolved Hide resolved
mm2src/coins/solana.rs Outdated Show resolved Hide resolved
mm2src/coins/solana.rs Outdated Show resolved Hide resolved
mm2src/coins/solana.rs Outdated Show resolved Hide resolved
@shamardy
Copy link
Collaborator

shamardy commented Jun 6, 2024

@mj-blockydevs first step is to merge with latest dev to resolve conflicts

Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas+instead@blockydevs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas+instead@blockydevs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas+instead@blockydevs.com>
@mj-blockydevs
Copy link
Collaborator

Recent updates:

  • Merged the dev branch into the solana-swaps-poc branch.
  • Resolved all conflicts.
  • Made it possible to run and build the app without the --feature enable-solana flag.
  • Implemented Clippy suggestions.
  • Updated tests to work correctly with new function implementations.

Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas+instead@blockydevs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants