-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PHP 8.2 and Other Related Issues #640
base: master
Are you sure you want to change the base?
Fix PHP 8.2 and Other Related Issues #640
Conversation
I think you should extract into another PR the actual changes of the code and keep this one for the tooling |
This reverts commit f4e69f4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This definitely looks good now
Co-authored-by: William Desportes <williamdes@wdes.fr>
What's the expected timeframe for merging this PR into the master branch? |
hi @iulian03, would you please review my pr and prepare for release? |
Hi @iulian03, @fredericdelordm, I hope you're doing well. I submitted a pull request about a month ago to address the MangoPay PHP SDK's incompatibility with PHP 8.2 and later versions. As a developer relying on this SDK, it's crucial for me and others to have it working with the latest PHP versions. I kindly request your review of the pull request and would greatly appreciate your feedback. If you find the changes satisfactory, it would be fantastic if you could prepare a new release incorporating these compatibility enhancements. I've been eagerly waiting for an update on the review and release for the past month, and I also reached out about 3 weeks ago seeking your(@iulian03) intentions. Any information you can provide on the progress would be much appreciated. Thank you for your time and consideration. Looking forward to your response. |
Hi @mralaminahamed , Sorry for the late response. We will check your PR, thank you for the contribution! |
… different types
@williamdes, I've made the changes based on your feedback. Could you please take another look and let me know if there's anything else that needs to be addressed? Thanks for your time and guidance! |
Changes Proposed in this Pull Request:
Related Issue(s) and PR(s):
How to Test the Changes in this Pull Request:
Changelog Entry:
Self-Review Checklist:
Additional Notes: