Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 8.2 and Other Related Issues #640

Open
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

mralaminahamed
Copy link

@mralaminahamed mralaminahamed commented Apr 30, 2024

Changes Proposed in this Pull Request:

  1. PHP 8.2 Compatibility: Resolved issues related to compatibility with PHP 8.2, ensuring the plugin functions smoothly on this PHP version without errors or warnings.
  2. PHP CS Fixer (3.*) Compatibility: Resolve issues related to compatibility with PHP CS Fixer 3.* and update configure file as per new guidelines.

Related Issue(s) and PR(s):

How to Test the Changes in this Pull Request:

  1. Ensure you have PHP 8.2 installed on your development environment.
  2. Apply this PR's changes to your local copy of the plugin.
  3. Test a payment to verify that the reported issues are resolved and enhancements work as expected.
  4. Check for any PHP warnings, errors, or unexpected behavior.

Changelog Entry:

  • Fixed: fix: Fatal error: Uncaught Error: Class "PhpCsFixer\Finder" not found on .php_cs file.
  • Fixed: PHP 8.2 compatibility issues and resolved added dynamicly called properties.

Self-Review Checklist:

  • Code follows WordPress coding standards.
  • Fixes or enhancements fully address the reported issues or goals.
  • Tested thoroughly on relevant environments.
  • Documentation and comments are updated.
  • No regressions introduced.

Additional Notes:

@williamdes
Copy link
Contributor

I think you should extract into another PR the actual changes of the code and keep this one for the tooling

@mralaminahamed mralaminahamed changed the title [IN-PROGRESS] Fix PHP 8.2 and Other Related Issues [IN-PROGRESS] Fix PHP 8.2, PHPCS and Other Related Issues Apr 30, 2024
@mralaminahamed mralaminahamed changed the title [IN-PROGRESS] Fix PHP 8.2, PHPCS and Other Related Issues [IN-PROGRESS] Fix PHP 8.2 and Other Related Issues Apr 30, 2024
@mralaminahamed mralaminahamed changed the title [IN-PROGRESS] Fix PHP 8.2 and Other Related Issues Fix PHP 8.2 and Other Related Issues Apr 30, 2024
MangoPay/PayOut.php Outdated Show resolved Hide resolved
Copy link
Contributor

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely looks good now

Co-authored-by: William Desportes <williamdes@wdes.fr>
.gitignore Outdated Show resolved Hide resolved
.php-cs-fixer.cache Outdated Show resolved Hide resolved
@mralaminahamed
Copy link
Author

What's the expected timeframe for merging this PR into the master branch?

@mralaminahamed
Copy link
Author

hi @iulian03, would you please review my pr and prepare for release?

@mralaminahamed
Copy link
Author

mralaminahamed commented Jun 3, 2024

hi @iulian03, would you please review my pr and prepare for release?

Hi @iulian03, @fredericdelordm,

I hope you're doing well. I submitted a pull request about a month ago to address the MangoPay PHP SDK's incompatibility with PHP 8.2 and later versions. As a developer relying on this SDK, it's crucial for me and others to have it working with the latest PHP versions.

I kindly request your review of the pull request and would greatly appreciate your feedback. If you find the changes satisfactory, it would be fantastic if you could prepare a new release incorporating these compatibility enhancements.

I've been eagerly waiting for an update on the review and release for the past month, and I also reached out about 3 weeks ago seeking your(@iulian03) intentions. Any information you can provide on the progress would be much appreciated.

Thank you for your time and consideration. Looking forward to your response.

MangoPay/KycDocument.php Outdated Show resolved Hide resolved
MangoPay/PayOut.php Outdated Show resolved Hide resolved
MangoPay/PayOut.php Outdated Show resolved Hide resolved
@iulian03
Copy link
Contributor

iulian03 commented Jun 3, 2024

Hi @mralaminahamed ,

Sorry for the late response. We will check your PR, thank you for the contribution!

MangoPay/PayOut.php Outdated Show resolved Hide resolved
@mralaminahamed
Copy link
Author

@williamdes, I've made the changes based on your feedback. Could you please take another look and let me know if there's anything else that needs to be addressed? Thanks for your time and guidance!

MangoPay/PayOut.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PHP 8.2 Support PHP 8.2 compatibility
3 participants