Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Signature redesign - Create metric tests #23979

Open
3 tasks
digiwand opened this issue Apr 11, 2024 · 1 comment · May be fixed by #24424
Open
3 tasks

[e2e] Signature redesign - Create metric tests #23979

digiwand opened this issue Apr 11, 2024 · 1 comment · May be fixed by #24424
Assignees
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-confirmations Push issues to confirmations team team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead

Comments

@digiwand
Copy link
Contributor

digiwand commented Apr 11, 2024

ref: #23552 (comment)

Create e2e tests:

  • Metrics
    • check we are tracking the redesigned UI is being used (while we have both new and old co-existing). For this we can add the value redesigned_confirmation to the ui_customizations property of all signature events when the redesigned UI is being displayed
    • check we are tracking opening of account info modal
@digiwand digiwand added the team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead label Apr 11, 2024
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Apr 11, 2024
@cryptotavares cryptotavares added the team-confirmations Push issues to confirmations team label Apr 24, 2024
@jpuri
Copy link
Contributor

jpuri commented Apr 26, 2024

@pnarayanaswamy pnarayanaswamy self-assigned this May 6, 2024
@pnarayanaswamy pnarayanaswamy linked a pull request May 8, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-confirmations Push issues to confirmations team team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants