Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: e2e redesign metrics and refactor #24424

Draft
wants to merge 31 commits into
base: develop
Choose a base branch
from
Draft

test: e2e redesign metrics and refactor #24424

wants to merge 31 commits into from
+948 −117

Conversation

pnarayanaswamy
Copy link
Contributor

@pnarayanaswamy pnarayanaswamy commented May 8, 2024 •
edited

Description

Open in GitHub Codespaces

Related issues

Fixes: #23979

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

digiwand and others added 21 commits May 1, 2024 22:45
@digiwand
refactor: ConfirmFooter data-testid "confirm-footer-button"
2c956d0
@digiwand
test:e2e: signature redesign personal_sign
4f018dc
@digiwand
test:e2e: signature eth_signTypedData
327e6ba
@digiwand
test:refactor: '127.0.0.1:8080' -> DAPP_URL_WITHOUT_SCHEMA
d81f87c
@digiwand
test:refactor require -> import
8334bb4
@digiwand
test:fix: require -> import
60571f2
@digiwand
test:refactor: snake case -> kebab case filenames
55fb8a5
@digiwand
test:fix: require FixtureBuilder
2b51b1f
@digiwand
test:e2e signature redesign deprecate isElementPresent
bd538cc
@digiwand
test: signature redesign reorganize imports
50f664d
@digiwand
test:fix: flaky personalSignVerifyECRecoverResult
bc779a3
@digiwand
test:e2e add signature redesign signTypedDataV3 test
364ccc2
@digiwand
test:e2e: signature redesign update test phrase
919703d
@digiwand
refactor: redesign signTypedDataV3 isElementPresent -> findElement
945ce71
@digiwand
test:e2e: create signature redesign signTypedDataV4
a3b61d6
@digiwand
test:e2e: create signature redesign permit
4892b9c
@digiwand
refactor: clean whitespaces
169befb
@digiwand
test: create and use withRedesignConfirmationFixtures
5f10110
@digiwand
test: fix whitespace & newlines manually
a024071 
- looks like eslint it not setup for these files
@digiwand
test:e2e: add signature redesign reject tests
007839e
@pnarayanaswamy
test: Add e2e for redesign metrics and refector
c5278da
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pnarayanaswamy pnarayanaswamy changed the title Test e2e redesign metrics test: e2e redesign metrics and refactor May 8, 2024
@pnarayanaswamy pnarayanaswamy added the team-confirmations Push issues to confirmations team label May 8, 2024
@digiwand digiwand mentioned this pull request May 9, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[e2e] Signature redesign - Create metric tests
3 participants
@pnarayanaswamy @pedronfigueiredo @digiwand