Signatures redesign - confirm button is disabled even if full content is visible and no scroll arrow is shown #24485
Assignees
Labels
release-11.18.0
Issue or pull request that will be included in release 11.18.0
release-blocker
This bug is blocking the next release
team-confirmations
Push issues to confirmations team
Comments
7 tasks
digiwand
added a commit
that referenced
this issue
May 14, 2024
…Bottom button with 16px or less scroll buffer (#24489) ## **Description** - Removes 16px buffer - Allow optional scroll buffer in useScrollRequired hook ## **Related issues** Fixes: #24485 ## **Manual testing steps** 1. Create sign request from OpenSea login 2. Observe scroll behavior ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/MetaMask/metamask-extension/assets/20778143/1b436528-b285-41c0-a365-98ce2aed7eec ### **After** https://github.com/MetaMask/metamask-extension/assets/20778143/4a42022a-1473-4f9c-b3a5-459510f221c2 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-11.18.0
digiwand
added a commit
that referenced
this issue
May 14, 2024
…Bottom button with 16px or less scroll buffer (#24489) ## **Description** - Removes 16px buffer - Allow optional scroll buffer in useScrollRequired hook ## **Related issues** Fixes: #24485 ## **Manual testing steps** 1. Create sign request from OpenSea login 2. Observe scroll behavior ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/MetaMask/metamask-extension/assets/20778143/1b436528-b285-41c0-a365-98ce2aed7eec ### **After** https://github.com/MetaMask/metamask-extension/assets/20778143/4a42022a-1473-4f9c-b3a5-459510f221c2 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
7 tasks
danjm
pushed a commit
that referenced
this issue
May 20, 2024
…d "Confirm" button with 16px or less scroll buffer (#24527) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Cherry-pick [0e775fd](0e775fd) (#24489) into v11.17.0 [](https://codespaces.new/MetaMask/metamask-extension/pull/24527?quickstart=1) ## **Related issues** Fixes: #24485 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/24527?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is this about?
Confirm button should be enabled when full content is visible and the scroll to bottom arrow is not present.
Scenario
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
Screen.Recording.2024-05-10.at.12.30.06.mov
The text was updated successfully, but these errors were encountered: