-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Signature Redesign Disabled confirm button with missing ScrollToBottom button with 16px or less scroll buffer #24489
fix: Signature Redesign Disabled confirm button with missing ScrollToBottom button with 16px or less scroll buffer #24489
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [2a284d0]
Page Load Metrics (1218 ± 612 ms)
Bundle size diffs
|
export const useScrollRequired = (dependencies = []) => { | ||
export const useScrollRequired = ( | ||
dependencies = [], | ||
{ offsetPxFromBottom = 16 } = {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaning towards defaulting to 0. We can handle this in a separate PR
…h-16px-or-less-scroll-buffer
Builds ready [879f8ef]
Page Load Metrics (787 ± 602 ms)
Bundle size diffs
|
Builds ready [879f8ef]
Page Load Metrics (787 ± 602 ms)
Bundle size diffs
|
Builds ready [eec6c25]
Page Load Metrics (778 ± 594 ms)
Bundle size diffs
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24489 +/- ##
========================================
Coverage 67.48% 67.48%
========================================
Files 1288 1288
Lines 50153 50158 +5
Branches 13023 13025 +2
========================================
+ Hits 33842 33846 +4
- Misses 16311 16312 +1 ☔ View full report in Codecov by Sentry. |
Description
Related issues
Fixes: #24485
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2024-05-10.at.12.30.06.mov
After
CleanShot.2024-05-14.at.06.21.08.mp4
Pre-merge author checklist
Pre-merge reviewer checklist