Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update confirmations codeowners #24427

Merged
merged 1 commit into from
May 23, 2024

Conversation

cryptotavares
Copy link
Contributor

@cryptotavares cryptotavares commented May 8, 2024

Description

Updates the codeowners file to reference the new Confirmations team.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cryptotavares cryptotavares requested review from kumavis and a team as code owners May 8, 2024 08:16
Copy link
Contributor

github-actions bot commented May 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cryptotavares cryptotavares added the team-confirmations Push issues to confirmations team label May 8, 2024
@cryptotavares cryptotavares requested a review from danjm May 8, 2024 08:17
danjm
danjm previously approved these changes May 8, 2024
@cryptotavares cryptotavares dismissed stale reviews from pedronfigueiredo and danjm via 91bdd7a May 20, 2024 17:39
@cryptotavares cryptotavares force-pushed the chore/update-confirmations-codeowner branch from 51f12d1 to 91bdd7a Compare May 20, 2024 17:39
With the two teams merging, we are
updating the github team as well.
@cryptotavares cryptotavares force-pushed the chore/update-confirmations-codeowner branch from 91bdd7a to 190ecab Compare May 21, 2024 12:14
@metamaskbot
Copy link
Collaborator

Builds ready [190ecab]
Page Load Metrics (1304 ± 542 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint692751064622
domContentLoaded9411694
load57287113041130542
domInteractive9411694
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.39%. Comparing base (4a5cd3d) to head (190ecab).
Report is 26 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24427      +/-   ##
===========================================
- Coverage    67.40%   67.39%   -0.00%     
===========================================
  Files         1289     1289              
  Lines        50248    50248              
  Branches     13011    13011              
===========================================
- Hits         33865    33864       -1     
- Misses       16383    16384       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cryptotavares cryptotavares merged commit 38199bb into develop May 23, 2024
72 checks passed
@cryptotavares cryptotavares deleted the chore/update-confirmations-codeowner branch May 23, 2024 13:09
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.0.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants