-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update confirmations codeowners #24427
Merged
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
danjm
previously approved these changes
May 8, 2024
pedronfigueiredo
previously approved these changes
May 8, 2024
cryptotavares
dismissed stale reviews from pedronfigueiredo and danjm
via
May 20, 2024 17:39
91bdd7a
cryptotavares
force-pushed
the
chore/update-confirmations-codeowner
branch
from
May 20, 2024 17:39
51f12d1
to
91bdd7a
Compare
With the two teams merging, we are updating the github team as well.
cryptotavares
force-pushed
the
chore/update-confirmations-codeowner
branch
from
May 21, 2024 12:14
91bdd7a
to
190ecab
Compare
danjm
approved these changes
May 22, 2024
Builds ready [190ecab]
Page Load Metrics (1304 ± 542 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24427 +/- ##
===========================================
- Coverage 67.40% 67.39% -0.00%
===========================================
Files 1289 1289
Lines 50248 50248
Branches 13011 13011
===========================================
- Hits 33865 33864 -1
- Misses 16383 16384 +1 ☔ View full report in Codecov by Sentry. |
pedronfigueiredo
approved these changes
May 23, 2024
OGPoyraz
approved these changes
May 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the codeowners file to reference the new Confirmations team.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist