test: swap + send eth e2e tests #24449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
micaelae
force-pushed
the
swap-send-e2e-eth
branch
2 times, most recently
from
a96660e
to
c0ed904
Compare
micaelae
force-pushed
the
swap-send-e2e-eth
branch
5 times, most recently
from
f6d9ee1
to
f380839
Compare
micaelae
force-pushed
the
swap-send-e2e-eth
branch
3 times, most recently
from
729b7fd
to
a9bf603
Compare
micaelae
force-pushed
the
swap-send-e2e-eth
branch
5 times, most recently
from
59954b4
to
64eecd2
Compare
BZahory
reviewed
May 23, 2024
| // TODO does this need to be removed? Needs to be tested with non 1559 network | ||
| networkAndAccountSupports1559 | ||
| ? gasFee1559 | ||
| : `0x${String(gasPriceNon1559 ?? 0)}`, |
There was a problem hiding this comment.
Can we use addHexPrefix here instead
There was a problem hiding this comment.
Side note but is this not a numeric value? We would need to change the base in the next parameter as well if it's a hex
There was a problem hiding this comment.
If you search for GAS_PRICE_API_MOCK_RESULT or gasPricesCallbackMock it looks like the prices are in decimals
The infura https://gas.api.infura.io/networks/1/gasPrices api might be deprecated tho bc I can't find docs on it
georgewrmarshall
approved these changes
May 23, 2024
micaelae
force-pushed
the
swap-send-e2e-eth
branch
from
64eecd2
to
ca537b4
Compare
micaelae
force-pushed
the
swap-send-e2e-eth
branch
6 times, most recently
from
ec510e2
to
0f5804a
Compare
micaelae
force-pushed
the
swap-send-e2e-eth
branch
2 times, most recently
from
70d6f85
to
ad4b598
Compare
fix: send-hex-address tests fix: custom-token-send-transfer tests fix: ens test fix: erc721-interaction tests fix: custom-token-add-approve tests fix: snap-account-transfers tests fix: test-snap-txinsights tests fix: failing-contract tests fix: settings-security-reveal-srp tests fix: token-details test fix: add-hide-token tests fix: show-hex-data test fix: test-snap-txinsights-v2 tests fix: increase-token-allowance test fix: increase snap-account-transfers delay (flaky) fix: rm delay for swap-send-eth fix: contract-interactions test fix: snap-account-transfers fix: failing-contract tests fix: ens test fix: rm useEthFeeData
fix: show-hex-data.spec tests fix: swap-send-eth test
micaelae
force-pushed
the
swap-send-e2e-eth
branch
from
ad4b598
to
3e6bb55
Compare
BZahory
force-pushed
the
swap-send-e2e-eth
branch
from
b10e78c
to
7e438aa
Compare
BZahory
approved these changes
May 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist