fix: Place permission middleware ahead of all method implementations

[rekmarks]

Description

Adds all unrestricted RPC methods to the unrestrictedMethods array passed to the permission controller, and moves the permission middleware ahead of all RPC method implementations in setupProviderEngine. This forces us to add all methods that aren't permission to the unrestrictedMethods array, as a "method not found" error will be thrown otherwise. It's safer this way.

Related issues

Fixes: #24331

Manual testing steps

1. Go the test dapp
2. Ensure that everything is working normally
3. Repeat these steps for Snaps and MMI

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[rekmarks]

@MetaMask/snaps-devs @MetaMask/mmi tagging you guys to confirm that your RPC methods continue to work as expected.

[rekmarks]

Converting to draft while figuring out how best to fix wallet_invokeSnap (i.e. the sugar for wallet_snap), whose implementation assumes that it runs before the permission middleware.

Update: We will need a bump of @metamask/snaps-rpc-methods once the following PR is merged: MetaMask/snaps#2398

[metamaskbot]

Builds ready [653e514]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2225 ± 753 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	80	452	141	79	38
		domContentLoaded	9	302	36	64	31
		load	65	3924	2225	1569	753
		domInteractive	9	302	35	64	31

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 1.45 KiB (0.04%)
• ui: 0 Bytes (0.00%)
• common: 189 Bytes (0.00%)

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [611dac9]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1833 ± 699 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	180	102	28	13
		domContentLoaded	9	33	16	7	3
		load	51	3571	1833	1456	699
		domInteractive	9	32	16	7	3

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 1.45 KiB (0.04%)
• ui: 0 Bytes (0.00%)
• common: 189 Bytes (0.00%)

[codecov]

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.48%. Comparing base (d27a233) to head (611dac9).
Report is 59 commits behind head on develop.

❗ Current head 611dac9 differs from pull request most recent head 9c346cd. Consider uploading reports for the commit 9c346cd to get more accurate results

Files	Patch %	Lines
app/scripts/metamask-controller.js	80.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #24472      +/-   ##
===========================================
+ Coverage    67.37%   67.48%   +0.11%     
===========================================
  Files         1278     1289      +11     
  Lines        49881    50168     +287     
  Branches     12944    13015      +71     
===========================================
+ Hits         33605    33853     +248     
- Misses       16276    16315      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.