Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove UnconnectedAlert component and state #24473

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented May 10, 2024

Description

The new Multichain component removed the old UnconnectedAlert component usage; this PR removes the file and state involved.

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

N/A, just removes old component.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing added team-wallet-ux needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels May 10, 2024
@darkwing darkwing requested a review from a team as a code owner May 10, 2024 03:27
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@EtherWizard33 EtherWizard33 self-requested a review May 14, 2024 12:36
Copy link

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into the lint error that came up in the checks above.
I ran the repo from github codespaces, and yarn lint.
It's simply the removed component that needs to be removed from the duck file.
Here is a screenshot of the change i did to fix the lint.

Screenshot 2024-05-14 at 8 34 45 AM

@NidhiKJha NidhiKJha changed the title task: Remove UnconnectedAlert component and state fix: Remove UnconnectedAlert component and state May 15, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [489fdd9]
Page Load Metrics (1286 ± 589 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint60168992613
domContentLoaded104619105
load50294512861227589
domInteractive94619105
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 943 Bytes (0.03%)
  • ui: 76 Bytes (0.00%)
  • common: -4.64 KiB (-0.08%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants