Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test/e2e): Fix onboarding/onboarding.spec.js #24488

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

chore(test/e2e): Fix onboarding/onboarding.spec.js #24488

wants to merge 2 commits into from
+4 −0

Conversation

vthomas13
Copy link
Contributor

@vthomas13 vthomas13 commented May 10, 2024 •
edited by github-actions bot

Description

Flaky test: "MetaMask onboarding @no-mmi Verify that the user has been redirected to the correct page after creating a password for their new wallet"
Attempting to fix by adding await driver.findElement('[data-testid="create-password-new"]');before trying to fill.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vthomas13 vthomas13 marked this pull request as ready for review May 10, 2024 19:13
@vthomas13 vthomas13 requested a review from a team as a code owner May 10, 2024 19:13
@vthomas13 vthomas13 marked this pull request as draft May 14, 2024 15:49
@vthomas13
waiting for element to render before trying to fill; flaky e2e fix
304469d 
awaiting element render before trying to fill

fixing accidental deletion

removing initial change

typo fix
@vthomas13
testing using waitForSelector
0dc91c8
@legobeat legobeat mentioned this pull request May 15, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
team-extension-platform
Projects
PR review queue
Status: Needs dev review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vthomas13