Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update from eth-rpc-errors to @metamask/rpc-errors (cause edition) #24496

Draft
wants to merge 27 commits into
base: develop
Choose a base branch
from

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 13, 2024

Description

  • Upgrade from obsolete eth-rpc-errors to @metamask/rpc-errors

Open in GitHub Codespaces

Related issues

Blocked by

Blocking

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@legobeat legobeat added the DO-NOT-MERGE Pull requests that should not be merged label May 13, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat force-pushed the deps-eth-rpc-errors-testing2 branch 3 times, most recently from 81de478 to d2b1465 Compare May 13, 2024 04:50
@legobeat

This comment was marked as resolved.

@legobeat legobeat force-pushed the deps-eth-rpc-errors-testing2 branch 4 times, most recently from 1681c02 to 7dc9514 Compare May 13, 2024 06:57
@legobeat legobeat changed the title testing rpc-errors cause handling fix: testing rpc-errors cause handling May 13, 2024
@legobeat legobeat force-pushed the deps-eth-rpc-errors-testing2 branch 18 times, most recently from 2faf92d to 449fd01 Compare May 13, 2024 21:40
@legobeat legobeat force-pushed the deps-eth-rpc-errors-testing2 branch 2 times, most recently from a73305c to afa4f4b Compare June 6, 2024 20:32
@legobeat legobeat force-pushed the deps-eth-rpc-errors-testing2 branch from afa4f4b to 7d32586 Compare June 6, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file team-security
Projects
Status: Needs more work from the author
Development

Successfully merging this pull request may close these issues.

None yet

1 participant