[berkeley] Remove stop-slots from compile config #15589
Conversation
|
!ci-build-me |
| @@ -67,7 +67,7 @@ let max_event_elements = 100 | |||
|
|
|||
| let max_action_elements = 100 | |||
|
|
|||
| [%%inject "network_id", network] | |||
| let network_id = "testnet" | |||
There was a problem hiding this comment.
Wouldn't this impact when building from source using mainnet profile?
There was a problem hiding this comment.
Yes, but only locally. In CI, this is still true. It's also only used in one janky GraphQL endpoint anyway, where it's overridden by the ledger.name in the runtime config.
There was a problem hiding this comment.
It seems like there are members in the community that build from source and not use the deb or docker images from releases. So we'll need to keep that option available
There was a problem hiding this comment.
It's also only used in one janky GraphQL endpoint anyway, where it's overridden by the ledger.name in the runtime config.
oh :/
|
Is this change necessary in It looks safe and sane, but I'd prefer to avoid any changes to As for these changes, I suggest we merge them to |
This PR removes the stop slots from the compile config.
These caused a previous issue where a release was baked expecting it to use the compile config, where CI is not set up to do so. Instead, we remove the options so that they are only injected in the correct location: in the runtime config that we provide for the network.