-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[berkeley] Don't bootloop at startup for non-seed nodes #15609
Open
mrmr1993
wants to merge
4
commits into
berkeley
Choose a base branch
from
feature/no-bootloop-before-genesis
base: berkeley
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confirmed working as intended with the following command:
|
emberian
reviewed
May 8, 2024
@@ -464,6 +464,16 @@ let create_sync_status_observer ~logger ~is_seed ~demo_mode ~net | |||
let offline_shutdown_delay = Time.Span.of_min 25. in | |||
let after_genesis = | |||
let genesis_timestamp = | |||
(* Horrifyingly, this completely disregards the timestamp from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is horrifying and indeed explains the mysterious behavior i have been seeing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bootloop at startup for nodes without the
--seed
flag, where nodes will detect that they're offline (i.e. receiving no messages) and restart every 5 minutes.A 'mitigation' for this previously existed, but didn't work as intended for the reasons given in the newly-added comment. This code should eventually be removed.
This is currently untested. I am travelling and have been so far unable to.