Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding graphql query for snarked ledger #15611

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

adding graphql query for snarked ledger #15611

wants to merge 1 commit into from

Conversation

svv232
Copy link
Member

@svv232 svv232 commented May 7, 2024

Explain your changes:

  • I added a snarkLedger object to the block object in graphql. The idea is to emulate the snark leger export functionality in the daemon rpc calls in graphql.

Explain how you tested your changes:

  • I need some additional assistance testing this. Despite my best efforts, I can't seem to get a block height of greater than size one on my local network. Ideally this query would be run on a network with a reasonably large snark ledger, along with a unit test. If anyone can walk me through doing this, or help me get my local network set up that would be a huge help.
Screenshot 2024-05-06 at 8 40 31 PM

Ch=

@svv232 svv232 requested a review from a team as a code owner May 7, 2024 01:44
@svv232
Copy link
Member Author

svv232 commented May 7, 2024

!ci-build-me

@ghost-not-in-the-shell
Copy link
Member

The PR seems good to me. This can be tested using the mina_local_network script.

@mrmr1993
Copy link
Member

hopefully closes #12706

This doesn't quite address the issue, because it only returns the accounts and not the merkle path.

mrmr1993
mrmr1993 requested changes May 13, 2024
View reviewed changes
src/lib/mina_graphql/types.ml
let json_ls =
List.map
~f:(fun acc ->
acc |> Account.to_yojson |> Yojson.Safe.to_basic )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of casting this to JSON, can you try to use the Types.AccountObj.account return type?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GraphQL query for accounts + merkle paths in snarked ledgers
3 participants
@svv232 @ghost-not-in-the-shell @mrmr1993