Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ppx_version tests #15616

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Fix ppx_version tests #15616

wants to merge 1 commit into from

Conversation

georgeee
Copy link
Member

@georgeee georgeee commented May 8, 2024

Problem: ppx_version tests do not pass.

Solution: fix bounded_types usage and comment out a test that can't be trivially fixed.

Ideally, this commit is followed by another one that uncomments the bad_version_syntax_missing_versioned test execution.

Explain how you tested your changes:

  • Ran the ppx_version tests via Makefile

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

@georgeee georgeee requested a review from a team as a code owner May 8, 2024 08:37
@georgeee
Copy link
Member Author

georgeee commented May 8, 2024

@nholland94 could you explain your motivation for the change https://github.com/MinaProtocol/mina/pull/15195/files#diff-4639a9ab80fa8921be722da5501c054606e7c4cea41eab2134f9669492f052ee (part of #15195)?

It is the reason for test bad_version_syntax_missing_versioned failing. AFAIU, we do not check for %%versioned wrapping existence after your commit (and this is why the test is failing).

If this is intentional, docs have to be updated. And also function is_versioned_type_lident (and maybe some others too) are to be removed as unused code.

It seems to me though that the change wasn't intentional. Is there a problem if I just revert your whole change to src/lib/ppx_version/lint_version_syntax.ml?

Problem: ppx_version tests do not pass.

Solution: fix bounded_types usage and comment out a test that can't be
trivially fixed.

Ideally, this commit is followed by another one that uncomments the
bad_version_syntax_missing_versioned test execution.
@georgeee georgeee marked this pull request as draft May 8, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant