Rename libp2p_helper in go.nix #15627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgeee
changed the title
rbonichon
approved these changes
May 13, 2024
| @@ -74,6 +74,10 @@ final: prev: { | |||
| cp -r --reflink=auto ${final.libp2p_ipc_go}/ vendor/libp2p_ipc | |||
| sed -i 's/.*libp2p_ipc.*//' go.mod | |||
| ''; | |||
| # For compatibility with mina's child_processes library | |||
| postInstall = '' | |||
| mv $out/bin/libp2p_helper $out/bin/mina-libp2p_helper | |||
There was a problem hiding this comment.
Yes! That's nice to be able to avoid some issues automatically
|
!ci-build-me |
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move libp2p helper from
bin/libp2p_helpertobin/mina-libp2p_helperin generated derivation.This allows importing derivation as
buildInputwithout use of environment variable (not used in this PR, but will be used in future work).Affects only nix, changes effectively nothing in operation of it, just updates some internals.
Explain how you tested your changes:
Checklist: