Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make internal_tracing.context_logger a public lib #15629

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

georgeee
Copy link
Member

@georgeee georgeee commented May 13, 2024

This resolves a circular package-to-package dependency between mina_base and internal_tracing.

Clarification

It's package-to-package circular dependency, not libray-to-library.
Dune handles it well.
But dependency diagram becomes way less readable, also it makes packages incompatible with findlib-based installation approach (because one can't install packages one by one, they depend on one other).

Explain how you tested your changes:

  • Mina compiles

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

This resolves a circular package-to-package dependency between mina_base
and internal_tracing.
@georgeee georgeee requested review from a team as code owners May 13, 2024 13:26
Copy link
Member

@rbonichon rbonichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is okay. Approving

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants