Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use public library names #15631

Open
wants to merge 4 commits into
base: georgeee/promote-kimchi-libs
Choose a base branch
from
Open

Use public library names #15631

wants to merge 4 commits into from

Conversation

georgeee
Copy link
Member

Use public_name of different libraries instead of name when referring from dependencies of libraries corresponding to other packages.

Makes dune dependencies cleaner, also allows findlib-based installation.

Explain how you tested your changes:

  • Mina compiles

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

@georgeee
Promote kimchi_backend_common and kimchi_pasta
f9c4132 
Promote these two sublibraries to be packages of their own. This allows
to remove three-layered sublibrary names.

More importantly, it removes some package-to-package circular
dependencies and overall makes things a bit cleaner.
@georgeee
Use public names for library deps
fc8db46 
Refer to mina_runtime_config, coda_genesis_ledger and ppx_version.runtime by public names
@georgeee
Add public_name to mina_base_test_helpers library
eb14f9b
@georgeee
Do not use private lib names outside package
8481ca2
@georgeee georgeee requested review from a team as code owners May 13, 2024 13:41
@georgeee georgeee force-pushed the georgeee/promote-kimchi-libs branch from f9c4132 to ba846f5 Compare May 13, 2024 17:01
@georgeee georgeee requested a review from a team as a code owner May 13, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbonichon rbonichon rbonichon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@georgeee @rbonichon