Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not call ocamlformat from dune #15632

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

georgeee
Copy link
Member

It's a trick that doesn't seem to be necessary and isn't the cleanest one.

Explain how you tested your changes:

  • Mina compiles

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

It's a trick that doesn't seem to be necessary and isn't the cleanest
one.
@georgeee georgeee requested review from a team as code owners May 13, 2024 13:44
Copy link
Member

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend closing.

@@ -164,7 +163,7 @@
CARGO_TARGET_DIR
"%{read:dune-build-root}/cargo_kimchi_bindgen"
(run cargo run %{targets}))
(run ocamlformat -i %{targets}))))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to run ocamlformat here, otherwise the results are extremely ugly. The crypto team needs to explicitly look at these files.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see...

I assumed formatting was introduced mainly to avoid issues with committing files and running make reformat-diff before commit.

@dannywillems
Copy link
Member

dannywillems commented May 14, 2024

There is a more elegant solution which is using built-in fmt in dune, with dune fmt, and get rid of reformat. Source: https://ocaml.org/docs/formatting-your-code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants