Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mina version wisely #15638

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

georgeee
Copy link
Member

Problem: Module mina_version uses mina_version.normal as the default
implementation which causes recompilation of most of the project on
every commit.

Solution:

  • use mina_version.dummy as the default implementation
  • rename mina_version_normal to mina_version_compiled
  • use mina_version_compiled in all archive, rosetta and archive
    executables

This PR also makes mina_version_compiled a separate package (not part of
mina_version). While this is unnecessary for the purpose of PR, it eases
dependency analysis on package level vs. library level. This is useful
for some work that will be introduced in follow-up PRs.

Explain how you tested your changes:

  • Mina compiles
  • Compiled executables show correct commit id when mina version is called

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

Problem: Module mina_version uses mina_version.normal as the default
implementation which causes recompilation of most of the project on
every commit.

Solution:

* use mina_version.dummy as the default implementation
* rename mina_version_normal to mina_version_compiled
* use mina_version_compiled in all archive, rosetta and archive
  executables

This PR also makes mina_version_compiled a separate package (not part of
mina_version). While this is unnecessary for the purpose of PR, it eases
dependency analysis on package level vs. library level. This is useful
for some work that will be introduced in follow-up PRs.
This change updates ocaml.nix after changes to mina_version package
usage (default module, introduction of mina_version_compiled).
@georgeee georgeee requested review from a team as code owners May 13, 2024 13:55
@georgeee georgeee changed the title Georgeee/use mina version wisely Use mina version wisely May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant