-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Consensus] enable tonic #17816
[Consensus] enable tonic #17816
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
@@ -2202,6 +2203,9 @@ impl ProtocolConfig { | |||
|
|||
// Enable resharing at same initial version | |||
cfg.feature_flags.reshare_at_same_initial_version = true; | |||
|
|||
// Use tonic networking for Mysticeti. | |||
cfg.feature_flags.consensus_network = ConsensusNetwork::Tonic; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Protocol version 46 has been already deployed in testnet - is it ok to go and change now the flag values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I didn't realize version 46 got picked into the 1.25 release.
Description
Enable tonic networking for Mysticeti.
Test plan
CI
Private testnet: tonic has been the default for awhile.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.