Update graphql e2e tests to protocol version 45 #17819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… automatically update all tests protocol version
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@halfprice is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
halfprice
force-pushed
the
zhewu/graph-ql-test-to-45
branch
from
4af4b8a
to
6c8a1cf
Compare
halfprice
requested review from
amnn,
wlmyng,
stefan-mysten,
emmazzz and
suiwombat
as code owners
7 tasks
amnn
approved these changes
May 20, 2024
There was a problem hiding this comment.
Thanks @halfprice ! Minor nit on the way the script is structured, but the change itself looks good.
Comment on lines
15
to
16
| f"init --protocol-version {old_version} --", | ||
| f"init --protocol-version {new_version} --", |
There was a problem hiding this comment.
This is a little bit brittle (as opposed to testing for lines containing //# init and then searching for --protocol-version somewhere in that line.
There was a problem hiding this comment.
Thanks for the review and suggestion @amnn ! Script updated to search for //# init first and then replace --protocol-version` with new version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates graphql e2e tests' protocol version to 45.
It also adds a script
update-graphql-e2e-test-protocol-version.pythat search through move code with specific protocol version, and replace it with new version. To use it:python3 update_graphql_e2e_test_protocol_version.py [--yes-to-all] [--dry-run]And then follow the prompts. It only updates the protocol version in move files now. To update the snapshot, one also needs to run
env UB=1 cargo nextest run --features pg_integrationinsidecrates/sui-graphql-e2e-tests.afterwards (with postgres running).
Test plan
Test only updates.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.